Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Issued JWK / Presented JWK Protected Headers #142

Merged
merged 6 commits into from
Oct 20, 2024

Conversation

dwaite
Copy link
Collaborator

@dwaite dwaite commented Oct 20, 2024

New headers instead describe Issued/Presented Keys as part of CBOR addition.

This resulted in a slightly larger change with some additional editorial cleanups.

  1. The Proof Key and Presented Key definitions were in JWP, while the registry was in JPA. Moved the registry to JWP.
  2. The text was simplified by referring to e.g. "Proof Key protected header" rather than "the proof_key issuer protected header value"
  3. Requirements and usage purpose information inline in the algorithms leveraging these header parameters were moved to JWP under the header definitions.
  4. There was clarification in the new definition that the header parameters are not mandatory in general (specific algorithms mandate them).

Headers to instead describe Issued/Presented Keys
as part of CBOR addition.

This resulted in a slightly larger change with
some additional editorial cleanups.

1. The Proof Key and Presented Key definitions were in JWP,
   while the registry was in JPA. Moved the registry to JWP.
2. The text was simplified by referring to e.g.
   "Proof Key protected header" rather than
   "the `proof_key` issuer protected header value"
3. Requirements and usage purpose information
   inline in the algorithms leveraging these
   header parameters were moved to JWP under the
   header definitions.
4. There was clarification in the new definition
   that the header parameters are not mandatory in
   general (specific algorithms mandate them).
@dwaite dwaite mentioned this pull request Oct 20, 2024
7 tasks
@selfissued selfissued merged commit f7fbfeb into cbor-serialization Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants