-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add campusnotexists and exists by initial registration pattern #121
Open
GusttavoSoares
wants to merge
16
commits into
develop
Choose a base branch
from
feature/registration-pattern-internship-email-tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: add campusnotexists and exists by initial registration pattern #121
GusttavoSoares
wants to merge
16
commits into
develop
from
feature/registration-pattern-internship-email-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve as issues #127 e #120 e se relaciona com o pull request #136.
Esse pull request adiciona os testes para os métodos
existsByInternshipSectorEmail
eexistsByInitialRegistrationPattern
, que estão localizados na classeCampusRepository
. Além disso, foi adicionado noCampusServiceImpl
otoUpperCase
nos métodosgetAbbreviation
egetInitialRegistrationPattern
, quando cria e atualiza algum campus, dessa forma, os valores dos atributosabbreviation
einitialRegistrationPattern
serão sempre salvos em letra maiúscula.As modificações relacionadas aos testes podem ser verificadas ao rodar a classe CampusRepositoryTest. Já a alteração feita no CampusService, pode ser vista por meio do Postman.
POST /campuses colocando initial registration pattern com valores em minúsculo
POST /campuses colocando abbreviation com valores em minúsculo
PUT /campuses colocando initial registration pattern com valores em minúsculo
PUT /campuses colocando abbreviation com valores em minúsculo
GET / campuses e GET/ campuses/ id