Skip to content

When clicking on "More recommendations" while logged out, don't use… #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alice-blue
Copy link
Contributor

@alice-blue alice-blue commented Jan 24, 2025

search terms that require being logged in.

Also, move "More recommendations" to the end to be consistent with the other components on the home page. (In the other section headlines, the headline space is used for the headline itself and possibly a link for adding new things to the database. "More recommendations" isn't that type of link.)

Addresses #1268

…arch terms that require being logged in. Also, move "More recommendations" to the end to be consistent with the other components on the home page.
@dfabulich dfabulich requested a review from salty-horse February 3, 2025 07:03
@dfabulich
Copy link
Collaborator

I'm happy to move the link, but in #1268, you ask, "should it?" and I'm not really sure.

It seems "simpler" to just always link to a search for played:no willplay:no wontplay:no reviewed:no rated:no, and the link does work for logged out users; it just doesn't accomplish much, because all of those search filters silently do nothing when you're logged out.

@salty-horse Do you have an opinion about whether we should link to played:no willplay:no wontplay:no reviewed:no rated:no when you're logged out?

@alice-blue
Copy link
Contributor Author

Possibly I was thinking that the extra prefixes could slow down the query unnecessarily, but I guess that's not the case?

The way the link works now, if someone uses it while logged out, it might be confusing when those willplay/wontplay/played search terms show up on the screen but don't seem to do anything. On the other hand, if those search terms don't show up, then people might never realize that recommendations are supposed to take willplay/wontplay/played into account, and they won't think to log in to get better recommendations.

So maybe it's better to just show the search terms regardless.

Copy link
Collaborator

@salty-horse salty-horse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's technically still "more recommendations", no? I'm OK with keeping the current search terms.

@alice-blue
Copy link
Contributor Author

I'm happy to move the link

I filed #1276 for just this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants