Fixes Conflict of @js @css with L9+ #149
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so when using any package using
@js
helpers or by myself using@js
in some code, getting crashASSET is not defined
andArray called on
and many many others errors, at first I didn't understand from where it's coming from, but after 2 days of debugging I found it was because of@js
helpers and searched which packages causing it, and it was this package,I think that's because that the package was created from L5+,
I though of renaming it to
@themeJS
, but I see users on L9 Commit 94fed84d L10 #143 L11 #145 already using it.so this will be a breaking change for them.
So I added an option to disable it for users who have conflicts like me.
but for the feature, this must be renamed or removed.
Related:
fixes #148
Want to use this right now?
in composer.json add
Quick note for testing
you need to
php artisan optimize:clear
after changing this config value (idk why, but somehow laravel caches blade directives by itself, so if it was enabled, you need to clear cache and it won't be registered again)