Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Count of Smaller Numbers After Self #89

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Piyush6869
Copy link

@Piyush6869 Piyush6869 commented Oct 10, 2023

Title of the problem

Checklist before requesting a review

  • I have checked the guide for contributions.
  • I have added the description at the top of the solution file.
  • I have added a test file for the problem.
  • I have added an entry to the README file with a link to the new file.
  • I have run linter (npx eslint LeetcodeProblems LeetcodeProblemsTests) and unit tests (node Test.js) and they pass. More info.

Check the guide and this PR example.

Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! thanks for contributing.

Could you add:

  • The problem at the top of the file (exapmle)
  • A test file with a few scenarios (example)
  • A link to this problem in the Readme like this

Thanks!

Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository is only for Javascript at the moment. Could you rewrite the Python solution into JS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants