Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#167 - Fix configuration bug setting api_version #168

Merged
merged 2 commits into from
Jan 6, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix configuration bug setting api_version
frenesim committed Jan 3, 2025
commit 85c421ddf76b0b8c22c4e4d411d1fbe78f48a308
2 changes: 1 addition & 1 deletion lib/whatsapp_sdk/api/client.rb
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ class Client

def initialize(
access_token = WhatsappSdk.configuration.access_token,
api_version = ApiConfiguration::DEFAULT_API_VERSION,
api_version = WhatsappSdk.configuration.api_version,
logger = nil,
logger_options = {}
)
11 changes: 11 additions & 0 deletions test/whatsapp/api/client_test.rb
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
require 'test_helper'
require 'api/client'
require 'api/api_configuration'
require 'whatsapp_sdk'

module WhatsappSdk
module Api
@@ -50,6 +51,16 @@ def test_send_request_delete_with_success_response
assert_nil(response_body)
end

def test_set_api_version_in_config
WhatsappSdk.configure do |config|
config.api_version = 'v16.0'
end
assert_match "v16.0", WhatsappSdk::Api::Client.new.inspect
WhatsappSdk.configure do |config|
config.api_version = Api::ApiConfiguration::DEFAULT_API_VERSION
end
end

def test_valid_api_version
invalid_api_version = 'v16.0'
assert_silent do