Merge branch 'main' into julien/v29

changelog.md

@@ -10,8 +10,9 @@
 
 ### Changes
 
+- [#3993](https://github.com/ignite/cli/pull/3993) Oracle scaffolding was deprecated and has been removed
 - [#3959](https://github.com/ignite/cli/pull/3959) Remove app name prefix from the `.gitignore` file
-- [#3962](https://github.com/ignite/cli/pull/3962) Rename all RPC endpoints and autocli commands generated for `map`/`list`/`single` types 
+- [#3962](https://github.com/ignite/cli/pull/3962) Rename all RPC endpoints and autocli commands generated for `map`/`list`/`single` types
 - [#3972](https://github.com/ignite/cli/pull/3972) Skip Ignite app loading for some base commands that don't allow apps
 - [#3976](https://github.com/ignite/cli/pull/3976) Remove error checks for Cobra command value get calls
 - [#3983](https://github.com/ignite/cli/pull/3983) Bump `cosmos-sdk` to `v0.50.4` and `ibc-go` to `v8.1.0`

ignite/cmd/scaffold.go

@@ -129,7 +129,6 @@ with an "--ibc" flag. Note that the default module is not IBC-enabled.
 		NewScaffoldMessage(),
 		NewScaffoldQuery(),
 		NewScaffoldPacket(),
-		NewScaffoldBandchain(),
 		NewScaffoldVue(),
 		NewScaffoldReact(),
 	)

ignite/services/scaffolder/component.go

@@ -130,7 +130,6 @@ func checkForbiddenComponentName(name multiformatname.Name) error {
 	// Check with names already used from the scaffolded code
 	switch name.LowerCase {
 	case
-		"oracle",
 		"logger",
 		"keeper",
 		"query",
@@ -199,32 +198,6 @@ func checkGoReservedWord(name string) error {
 	return nil
 }
 
-// checkForbiddenOracleFieldName returns true if the name is forbidden as an oracle field name.
-//
-// Deprecated: This function is no longer maintained.
-func checkForbiddenOracleFieldName(name string) error {
-	mfName, err := multiformatname.NewName(name, multiformatname.NoNumber)
-	if err != nil {
-		return err
-	}
-
-	// Check with names already used from the scaffolded code
-	switch mfName.UpperCase {
-	case
-		"CLIENTID",
-		"ORACLESCRIPTID",
-		"SOURCECHANNEL",
-		"CALLDATA",
-		"ASKCOUNT",
-		"MINCOUNT",
-		"FEELIMIT",
-		"PREPAREGAS",
-		"EXECUTEGAS":
-		return errors.Errorf("%s is used by Ignite scaffolder", name)
-	}
-	return nil
-}
-
 // containsCustomTypes returns true if the list of fields contains at least one custom type.
 func containsCustomTypes(fields []string) bool {
 	for _, field := range fields {

ignite/services/scaffolder/component_test.go

@@ -21,7 +21,7 @@ func TestCheckForbiddenComponentName(t *testing.T) {
 		},
 		{
 			name:        "should prevent forbidden name",
-			compName:    "oracle",
+			compName:    "genesis",
 			shouldError: true,
 		},
 	}