Skip to content

Commit

Permalink
fix: correct ignite app gRPC server stop issue (#3831)
Browse files Browse the repository at this point in the history
* fix: correct ignite app gRPC server stop issue

* chore: update changelog

* chore: remove redundant stop function result

Co-authored-by: Julien Robert <[email protected]>

---------

Co-authored-by: Julien Robert <[email protected]>
  • Loading branch information
jeronimoalbi and julienrbrt authored Dec 11, 2023
1 parent 3a5a40d commit 94116d8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Fixes

- [#3831](https://github.com/ignite/cli/pull/3831) Correct ignite app gRPC server stop memory issue
- [#3825](https://github.com/ignite/cli/pull/3825) Fix a minor Keplr type-checking bug in TS client

### Features
Expand Down
8 changes: 7 additions & 1 deletion ignite/services/plugin/protocol.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,13 @@ func (c client) startClientAPIServer(api ClientAPI) (uint32, func()) {
return srv
})

return brokerID, func() { srv.Stop() }
stop := func() {
if srv != nil {
srv.Stop()
}
}

return brokerID, stop
}

type server struct {
Expand Down

0 comments on commit 94116d8

Please sign in to comment.