chore: enable gci linter (#4159)

.github/workflows/test-lint.yml

@@ -35,7 +35,7 @@ jobs:
       - uses: golangci/golangci-lint-action@v6
         if: env.GIT_DIFF
         with:
-          version: v1.54.2
+          version: v1.58.0
           install-mode: goinstall
           args: --timeout 10m
           github-token: ${{ secrets.github_token }}

.golangci.yml

@@ -1,9 +1,5 @@
 run:
   tests: false
-  skip-dirs:
-    - ignite/ui
-#   # timeout for analysis, e.g. 30s, 5m, default is 1m
-#   timeout: 5m
 
 linters:
   disable-all: true
@@ -17,6 +13,7 @@ linters:
     - errchkjson
     - errorlint
     - exhaustive
+    - gci
     - goconst
     - gocritic
     - godot
@@ -47,6 +44,16 @@ linters:
     # - wsl
 
 linters-settings:
+  gci:
+    custom-order: true
+    sections:
+      - standard # Standard section: captures all standard packages.
+      - default # Default section: contains all imports that could not be matched to another section type.
+      - prefix(cosmossdk.io)
+      - prefix(github.com/cosmos/cosmos-sdk)
+      - prefix(github.com/cosmos/ibc-go
+      - prefix(github.com/cometbft/cometbft)
+      - prefix(github.com/ignite/cli)
   forbidigo:
     forbid:
       - p: ^fmt\.Errorf$
@@ -61,5 +68,9 @@ linters-settings:
             desc: Should be replaced by '"github.com/ignite/cli/ignite/pkg/errors"'
 
 issues:
+  exclude-dirs:
+    - ignite/ui
+  #   # timeout for analysis, e.g. 30s, 5m, default is 1m
+  #   timeout: 5m
   max-issues-per-linter: 0
   max-same-issues: 0

changelog.md

@@ -21,6 +21,7 @@
 
 ### Changes
 
+- [#4159](https://github.com/ignite/cli/pull/4159) Enable gci linter
 - [#4157](https://github.com/ignite/cli/pull/4157) Upgrade golang to 1.22
 - [#4094](https://github.com/ignite/cli/pull/4094) Scaffolding a multi-index map using `ignite s map foo bar baz --index foobar,foobaz` is no longer supported. Use one index instead of use `collections.IndexedMap`.
 - [#4058](https://github.com/ignite/cli/pull/4058) Simplify scaffolded modules by including `ValidateBasic()` logic in message handler.

ignite/cmd/chain_faucet.go

@@ -1,9 +1,10 @@
 package ignitecmd
 
 import (
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/spf13/cobra"
 
+	sdk "github.com/cosmos/cosmos-sdk/types"
+
 	"github.com/ignite/cli/v29/ignite/pkg/chaincmd"
 	"github.com/ignite/cli/v29/ignite/pkg/cliui"
 	"github.com/ignite/cli/v29/ignite/services/chain"

ignite/cmd/chain_simulate.go

@@ -3,9 +3,10 @@ package ignitecmd
 import (
 	"path/filepath"
 
-	"github.com/cosmos/cosmos-sdk/types/simulation"
 	"github.com/spf13/cobra"
 
+	"github.com/cosmos/cosmos-sdk/types/simulation"
+
 	"github.com/ignite/cli/v29/ignite/services/chain"
 )
 

ignite/cmd/node_query.go

@@ -3,10 +3,11 @@ package ignitecmd
 import (
 	"fmt"
 
-	"github.com/cosmos/cosmos-sdk/types/query"
 	"github.com/spf13/cobra"
 	flag "github.com/spf13/pflag"
 
+	"github.com/cosmos/cosmos-sdk/types/query"
+
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )
 

ignite/cmd/node_tx_bank_send.go

@@ -1,9 +1,10 @@
 package ignitecmd
 
 import (
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/spf13/cobra"
 
+	sdk "github.com/cosmos/cosmos-sdk/types"
+
 	"github.com/ignite/cli/v29/ignite/pkg/cliui"
 )
 

ignite/config/chain/parse.go

@@ -5,9 +5,10 @@ import (
 	"io"
 	"os"
 
-	"github.com/cosmos/cosmos-sdk/types/bech32"
 	"gopkg.in/yaml.v3"
 
+	"github.com/cosmos/cosmos-sdk/types/bech32"
+
 	"github.com/ignite/cli/v29/ignite/config/chain/version"
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )

ignite/pkg/cosmosaccount/cosmosaccount.go

@@ -7,6 +7,8 @@ import (
 	"os"
 
 	dkeyring "github.com/99designs/keyring"
+	"github.com/cosmos/go-bip39"
+
 	"github.com/cosmos/cosmos-sdk/codec"
 	"github.com/cosmos/cosmos-sdk/codec/types"
 	cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
@@ -15,7 +17,6 @@ import (
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/types/bech32"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
-	"github.com/cosmos/go-bip39"
 
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )

ignite/pkg/cosmosclient/cosmosclient.go

@@ -14,9 +14,10 @@ import (
 	"time"
 
 	"github.com/cenkalti/backoff"
-	rpcclient "github.com/cometbft/cometbft/rpc/client"
-	rpchttp "github.com/cometbft/cometbft/rpc/client/http"
-	ctypes "github.com/cometbft/cometbft/rpc/core/types"
+	gogogrpc "github.com/cosmos/gogoproto/grpc"
+	"github.com/cosmos/gogoproto/proto"
+	prototypes "github.com/cosmos/gogoproto/types"
+
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/client/tx"
@@ -30,9 +31,10 @@ import (
 	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
 	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
 	staking "github.com/cosmos/cosmos-sdk/x/staking/types"
-	gogogrpc "github.com/cosmos/gogoproto/grpc"
-	"github.com/cosmos/gogoproto/proto"
-	prototypes "github.com/cosmos/gogoproto/types"
+
+	rpcclient "github.com/cometbft/cometbft/rpc/client"
+	rpchttp "github.com/cometbft/cometbft/rpc/client/http"
+	ctypes "github.com/cometbft/cometbft/rpc/core/types"
 
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosaccount"
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosfaucet"

ignite/pkg/cosmosclient/gasometer.go

@@ -1,10 +1,11 @@
 package cosmosclient
 
 import (
+	gogogrpc "github.com/cosmos/gogoproto/grpc"
+
 	"github.com/cosmos/cosmos-sdk/client/tx"
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
 	txtypes "github.com/cosmos/cosmos-sdk/types/tx"
-	gogogrpc "github.com/cosmos/gogoproto/grpc"
 )
 
 // gasometer implements the Gasometer interface.

ignite/pkg/cosmosfaucet/cosmosfaucet.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	sdkmath "cosmossdk.io/math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	chaincmdrunner "github.com/ignite/cli/v29/ignite/pkg/chaincmd/runner"

ignite/pkg/cosmosfaucet/transfer.go

@@ -7,6 +7,7 @@ import (
 	"time"
 
 	sdkmath "cosmossdk.io/math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	"github.com/ignite/cli/v29/ignite/pkg/chaincmd"

ignite/pkg/cosmostxcollector/adapter/postgres/postgres.go

@@ -8,9 +8,10 @@ import (
 	"fmt"
 	"net/url"
 
-	ctypes "github.com/cometbft/cometbft/rpc/core/types"
 	"github.com/lib/pq"
 
+	ctypes "github.com/cometbft/cometbft/rpc/core/types"
+
 	"github.com/ignite/cli/v29/ignite/pkg/cosmosclient"
 	"github.com/ignite/cli/v29/ignite/pkg/cosmostxcollector/query"
 	"github.com/ignite/cli/v29/ignite/pkg/errors"

ignite/pkg/cosmosutil/gentx.go

@@ -6,9 +6,11 @@ import (
 	"os"
 
 	sdkmath "cosmossdk.io/math"
-	"github.com/cometbft/cometbft/crypto/ed25519"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
+	"github.com/cometbft/cometbft/crypto/ed25519"
+
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )
 

ignite/services/chain/faucet.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	sdkmath "cosmossdk.io/math"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	chainconfig "github.com/ignite/cli/v29/ignite/config/chain"

ignite/services/chain/runtime.go

@@ -5,10 +5,11 @@ import (
 	"os"
 	"path/filepath"
 
-	sdktypes "github.com/cosmos/cosmos-sdk/types"
 	"github.com/nqd/flat"
 	"github.com/pelletier/go-toml"
 
+	sdktypes "github.com/cosmos/cosmos-sdk/types"
+
 	chainconfig "github.com/ignite/cli/v29/ignite/config/chain"
 	"github.com/ignite/cli/v29/ignite/pkg/chaincmd"
 	chaincmdrunner "github.com/ignite/cli/v29/ignite/pkg/chaincmd/runner"