feat: use `buf.build` binary to generate the proto files #3476

Pantani · 2023-03-30T21:18:27Z

Scaffold a chain:

ignite s chain github.com/ignite/earth && cd earth

You can also try to generate the profiles automatically. Ignite will install the buf binary for you:

buf generate --template proto/buf.gen.gogo.yaml

# Conflicts: # go.mod

# Conflicts: # ignite/cmd/model/chain_debug.go # ignite/cmd/model/chain_serve.go # ignite/pkg/cmdrunner/cmdrunner.go # ignite/pkg/cosmosgen/generate.go # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/cosmosgen/install.go # ignite/pkg/protoc/data/include/gogoproto/gogo.proto # ignite/templates/app/files/go.mod.plush # integration/doctor/testdata/config-ok.txt # integration/doctor/testdata/existing-tools.go.txt # integration/doctor/testdata/missing-tools.go.txt

ilgooz

I had an error with ignite g ts-client when running it on the latest commit of SPN. Looks like related to buf. Can you please take a look?

Also on SPN, shouldn't fundraising module auto discovered and added to the generated buf files?

Pantani · 2023-06-23T13:39:19Z

The Buf migration was missing for the generate tools. It's fixed now

ilgooz · 2023-06-26T14:13:10Z

ignite/pkg/buf/buf.go

+	// can't download this folder because is unused as a dependency. We need to
+	// change the workspace copying the files to another folder and generate the
+	// files.
+	if strings.Contains(protoDir, cosmosSDKModulePath) {


Suggested change

if strings.Contains(protoDir, cosmosSDKModulePath) {

@ilgooz, I made a double-check here. We can't remove this validation. Buf will solve the dependencies for the proto files. But we still need to go one by one of the Golang project dependencies and compile the proto files for the ts-client and open API spec generation. This workaround solves the issue regarding the invalid proto path (orm/internal) download into the go mod for cosmos-sdk buf workspace

ignite/cmd/chain.go

ignite/pkg/buf/buf.go

ignite/pkg/xos/cp.go

ignite/pkg/buf/buf.go

- Code generation using protoc is only supported by Ignite CLI v0.26.1 or older Wait til ignite/cli#3476 is released Signed-off-by: Julian Strobl <[email protected]>

* build buf pkg * fix go.mod * comment xbug pkg and bump buf versions * generate proto from buf and remove protoc and plugins * add proto ts and api generation * add changelog * fix proto and template path * fix wrong template for ts generation * fix api out path * fix ts out path and remove unused log * fix go.mod ident and sort * remove unused method * fix lint * fix wrong lint comment * remove unused tools * fix doctor for tools pkg * add missing tool dependency * add missing import * add global protoanalysis.NewCache to buf structure * fix proto module name * update go.mod * Update ignite/pkg/cosmosgen/generate_go.go method name Co-authored-by: Jerónimo Albi <[email protected]> * Update ignite/pkg/buf/buf.go remove unused ctx Co-authored-by: Jerónimo Albi <[email protected]> * fix wrong method call * fix deep tools * fix ignite doctor * fix buf.gen files * fix proto gen files * remove 3thrparty mod * thr modules openapi * add xos copy commands * fix wrong proto tmp path * remove unused method * update tools for the doctor command * unhlanded error * check if the buf files exists * remove unused ctx * fix changelog merge * fix unit tests and make more dynamic * Update changelog Co-authored-by: İlker G. Öztürk <[email protected]> * fix ts script generation and remove pulsar buf files * fix changelog * fix changelog * add migration for scaffold and generate commands * fix pre handler * fix rance condition * fix wrong app path for tools migrations * fix lint * rollback draft changes * fix ineffassign lint * fix wrong path * move buf pkg to cosmosbuf * increase test timeout --------- Co-authored-by: Jerónimo Albi <[email protected]> Co-authored-by: İlker G. Öztürk <[email protected]> Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Pantani <Pantani>

build buf pkg

6ec0fc8

Pantani self-assigned this Mar 30, 2023

Pantani added 13 commits March 30, 2023 18:21

fix go.mod

71ccd6c

Merge branch 'main' into feat/buf-build

89ca5ae

Merge remote-tracking branch 'origin/main' into feat/buf-build

bfcf049

# Conflicts: # go.mod

comment xbug pkg and bump buf versions

1119fd3

generate proto from buf and remove protoc and plugins

b06c098

add proto ts and api generation

de84c72

Merge branch 'main' into feat/buf-build

7f0a56e

add changelog

f71b889

fix proto and template path

453546c

fix wrong template for ts generation

f71d077

fix api out path

f95a8cf

fix ts out path and remove unused log

fc68882

fix go.mod ident and sort

49d1a25

Pantani marked this pull request as ready for review April 25, 2023 19:20

Pantani requested review from ilgooz and jeronimoalbi as code owners April 25, 2023 19:20

Pantani added 3 commits April 25, 2023 16:23

remove unused method

6a32471

fix lint

24b84c9

fix wrong lint comment

069eae6

Pantani changed the title ~~refactor: use buf.build binary to generate the proto files~~ feat: use buf.build binary to generate the proto files Apr 25, 2023

Pantani added 8 commits April 25, 2023 16:40

remove unused tools

610d616

fix doctor for tools pkg

d32f7b9

add missing tool dependency

65feeb4

add missing import

69b9f8d

add global protoanalysis.NewCache to buf structure

d3fbdfa

fix proto module name

69d9371

update go.mod

507ed36

fix changelog

47e0877

ilgooz requested changes Jun 23, 2023

View reviewed changes

add migration for scaffold and generate commands

d95e9b7

Pantani requested a review from ilgooz June 23, 2023 13:39

Danilo Pantani and others added 3 commits June 25, 2023 21:29

fix pre handler

fedfd47

fix rance condition

3cc098c

fix wrong app path for tools migrations

e7f4627

ilgooz reviewed Jun 26, 2023

View reviewed changes

Pantani added 4 commits June 26, 2023 17:25

fix lint

775f417

rollback draft changes

f28699d

fix ineffassign lint

660cc28

fix wrong path

7722c4e

Pantani requested a review from ilgooz June 26, 2023 22:02

Merge branch 'main' into feat/buf-build

7fe7cba

jeronimoalbi reviewed Jun 29, 2023

View reviewed changes

ignite/cmd/chain.go Outdated Show resolved Hide resolved

jeronimoalbi reviewed Jun 29, 2023

View reviewed changes

ignite/pkg/buf/buf.go Outdated Show resolved Hide resolved

jeronimoalbi reviewed Jun 29, 2023

View reviewed changes

ignite/pkg/xos/cp.go Show resolved Hide resolved

Merge branch 'main' into feat/buf-build

9a9f2c8

ilgooz reviewed Jun 29, 2023

View reviewed changes

ignite/pkg/buf/buf.go Outdated Show resolved Hide resolved

Pantani requested review from ilgooz and jeronimoalbi June 29, 2023 18:42

Pantani added 2 commits June 29, 2023 20:43

move buf pkg to cosmosbuf

383a07c

increase test timeout

6d6c00f

ilgooz approved these changes Jul 3, 2023

View reviewed changes

ilgooz merged commit f7acf08 into main Jul 3, 2023

ilgooz deleted the feat/buf-build branch July 3, 2023 12:39

jeronimoalbi mentioned this pull request Aug 3, 2023

Advice On Upgrading Project from Starport to Ignite #2568

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use `buf.build` binary to generate the proto files #3476

feat: use `buf.build` binary to generate the proto files #3476

Pantani commented Mar 30, 2023 •

edited

Loading

ilgooz left a comment

Pantani commented Jun 23, 2023

ilgooz Jun 26, 2023

Pantani Jun 26, 2023

feat: use buf.build binary to generate the proto files #3476

feat: use buf.build binary to generate the proto files #3476

Conversation

Pantani commented Mar 30, 2023 • edited Loading

ilgooz left a comment

Choose a reason for hiding this comment

Pantani commented Jun 23, 2023

ilgooz Jun 26, 2023

Choose a reason for hiding this comment

Pantani Jun 26, 2023

Choose a reason for hiding this comment

feat: use `buf.build` binary to generate the proto files #3476

feat: use `buf.build` binary to generate the proto files #3476

Pantani commented Mar 30, 2023 •

edited

Loading