feat: change app.go to v2 and add AppWiring feature #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod
# Conflicts: # ignite/cmd/model/chain_debug.go # ignite/cmd/model/chain_serve.go # ignite/pkg/cmdrunner/cmdrunner.go # ignite/pkg/cosmosgen/generate.go # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/cosmosgen/install.go # ignite/pkg/protoc/data/include/gogoproto/gogo.proto # ignite/templates/app/files/go.mod.plush # integration/doctor/testdata/config-ok.txt # integration/doctor/testdata/existing-tools.go.txt # integration/doctor/testdata/missing-tools.go.txt
Co-authored-by: Jerónimo Albi <[email protected]>
Co-authored-by: Jerónimo Albi <[email protected]>
# Conflicts: # ignite/templates/app/files/go.mod.plush
# Conflicts: # ignite/templates/app/files/app/app.go.plush
# Conflicts: # ignite/templates/app/files/app/app.go.plush
ignite/templates/module/create/files/base/x/{{moduleName}}/types/expected_keepers.go.plush
Show resolved
Hide resolved
|
I have been testing this PR and is looking good 👍 |
# Conflicts: # ignite/templates/app/files/app/app.go.plush
* feat: change scaffold commands to validate supported SDK version Validation was added to pre run handler to avoid applying buff or other migrations when the app is using an older SDK version. * refactor: fix deprecated `sdkerrors.Wrap` calls in app templates * fix: correct app path in scaffold pre run handler * fix: correct app template imports for SDK errors * fix: correct `errorsmod.Wrapf` error wrapping argument * test: increased integration test timeout to 20m
|
PR implements with the V2 app wiring features. also creates new modules with injected Pulsar proto files. |
github-actions
bot
added
component:ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
==========================================
+ Coverage 24.34% 24.89% +0.54%
==========================================
Files 298 287 -11
Lines 23745 23217 -528
==========================================
- Hits 5780 5779 -1
+ Misses 17452 16925 -527
Partials 513 513
|
jeronimoalbi
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
app.gov2 with the app wiring feature, and also creates modules with dependency injection with new Pulsar proto files.