Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cosmos-sdk v0.50.x #3659

Merged
merged 147 commits into from
Nov 20, 2023
Merged

feat: cosmos-sdk v0.50.x #3659

merged 147 commits into from
Nov 20, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Sep 18, 2023

close #3625

Description

  • Bump cosmos sdk to v0.50.x;
  • Bump ibc to v8.x;
  • Remove legacy amino codec;
  • Use context.Context insted sdk.Context for the keeper methods;
  • Use storeService instead key stores;
  • CMD package v2;
  • Move chain genesis cli commands to genesis namespace;
  • Use --query flag instead --events;
  • Some minor bug fixes;
  • Remove unused and deprecated templates;
  • New module discovery;
  • Move modules to the modules folder;
  • Use deep infection in the client side;

@Pantani Pantani self-assigned this Sep 18, 2023
@Pantani Pantani changed the title feat: sdk v0.50 cosmos-sdk v0.50.x Sep 19, 2023
@Pantani Pantani changed the title cosmos-sdk v0.50.x feat: cosmos-sdk v0.50.x Sep 19, 2023
@jeronimoalbi
Copy link
Member

@Pantani I'm having an issue with the IBC relayer when creating a connection:

Query failed with (6): rpc error: code = Unknown desc = unable to resolve type URL /ibc.core.client.v1.MsgCreateClient: tx parse error [cosmos/[email protected]/x/auth/tx/decoder.go:44] With gas wanted: '0' and gas used: '1174' : unknown request

I'm not sure but the registerIBCModules() might have to be changed to also register IBC core types. We might also need a new method to properly register IBC gRPC API routes.

With the latest changes MsgCreateClient message is available but there is another issue with the module parameters, triggered in the call to keeper's CreateClient():

✘ Query failed with (6): rpc error: code = Unknown desc = recovered: client params are not set in store

julienrbrt
julienrbrt previously approved these changes Nov 17, 2023
@julienrbrt
Copy link
Member

julienrbrt commented Nov 17, 2023

#3659 (comment)

Oh true, IBC modules only got their params upgrade in that version instead of v0.47.
We probably need to add this: https://github.com/cosmos/ibc-go/blob/v8.0.0/testing/simapp/app.go#L1002-L1015

@jeronimoalbi
Copy link
Member

jeronimoalbi commented Nov 17, 2023

#3659 (comment)

Oh true, IBC modules only got their params upgrade in that version instead of v0.47. We probably need to add this: https://github.com/cosmos/ibc-go/blob/v8.0.0/testing/simapp/app.go#L1002-L1015

I thought the same but changing registerIBCModules() in that way didn't fix the issue

@Pantani Pantani merged commit 561d77b into main Nov 20, 2023
35 checks passed
@Pantani Pantani deleted the feat/sdk-v0.50 branch November 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix: find a better way to add the expectec keepers for deepinject
9 participants