Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some lint issues #3691

Merged
merged 18 commits into from
Oct 19, 2023
Merged

fix: fix some lint issues #3691

merged 18 commits into from
Oct 19, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Oct 11, 2023

No description provided.

@Pantani Pantani self-assigned this Oct 11, 2023
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Oct 11, 2023
@jeronimoalbi
Copy link
Member

It seems the plugin tests fail now that the require.NoError were added.
Maybe they were missing on purpose in the original implementation. If that's the case a comment would be nice to explain why those errors are not asserted.

@Pantani Pantani changed the title feat: update CI lint fix: fix some lint issues Oct 16, 2023
Pantani added 3 commits October 18, 2023 15:17
Merge remote-tracking branch 'origin/main' into feat/update-lint
3f45ebc 
# Conflicts:
#	ignite/pkg/cosmosanalysis/app/app.go
#	ignite/pkg/placeholder/error.go
rollback lint ci file
0299ab5
remove unused files and comments
204ed78
julienrbrt
julienrbrt approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #3691 (35376ac) into main (7436d93) will increase coverage by 0.01%.
The diff coverage is 37.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3691      +/-   ##
==========================================
+ Coverage   25.11%   25.12%   +0.01%     
==========================================
  Files         287      287              
  Lines       23544    23557      +13     
==========================================
+ Hits         5912     5918       +6     
- Misses      17101    17106       +5     
- Partials      531      533       +2
Files Coverage Δ
...pkg/cosmostxcollector/adapter/postgres/postgres.go 41.60% <100.00%> (ø)
ignite/pkg/xhttp/response.go 61.90% <100.00%> (ø)
ignite/services/plugin/plugin.go 72.65% <100.00%> (ø)
ignite/pkg/cmdrunner/cmdrunner.go 37.34% <50.00%> (ø)
ignite/pkg/cosmosfaucet/http_openapi.go 0.00% <0.00%> (ø)
ignite/pkg/debugger/server.go 0.00% <0.00%> (ø)
ignite/pkg/openapiconsole/console.go 25.00% <0.00%> (ø)
ignite/pkg/xhttp/server.go 0.00% <0.00%> (ø)
ignite/pkg/cliui/clispinner/clispinner.go 0.00% <0.00%> (ø)
ignite/pkg/cliui/view/errorview/error.go 0.00% <0.00%> (ø)
... and 5 more

@Pantani Pantani merged commit d91979b into main Oct 19, 2023
26 checks passed
@Pantani Pantani deleted the feat/update-lint branch October 19, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages skip-changelog Don't check changelog for new entries type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @jeronimoalbi @julienrbrt