Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support autocli #3694

Merged
merged 162 commits into from
Nov 25, 2023
Merged

feat: support autocli #3694

merged 162 commits into from
Nov 25, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 12, 2023 •
edited by Pantani
Loading

closes #3663

DNM, based on #3659

Pantani and others added 30 commits September 15, 2023 14:29
update go.sum
7417c15
Merge remote-tracking branch 'origin/main' into feat/sdk-v0.50
046a47b
cosmos-sdk v0.50 imports
7356681
changes imports and update sdk
855c8bb
fix vet issues
bd4ea39
fix unused imports
994660b
bump ibc
6b9956b
@Pantani
Merge branch 'main' into feat/sdk-v0.50
be9288d
add changelog
91df772
update mocks
61fbfb4
rollback some test changes
fa9a1af
fix go version for the git workflows
cb22273
fix wront tx result for abci tx
5e1afdd
@Pantani
Merge branch 'main' into feat/sdk-v0.50
d07c286
fix wrong test case
f564ad0
remove some legacy methods and add module import blank to the `app_co…
d4e2507 
…nfig.go`
Merge remote-tracking branch 'origin/main' into feat/sdk-v0.50
736a2b2
remove legacy amino and fix genesis commands
811f0bb
fix module orders
c0322ec
remove unused modules and commands
b454808
fix module imports
7945ea9
use statstore instead key and memory store
a8047bd
fix missing runtime import for test keepers
dfe6ad9
remove typo
cb5e1df
fix missing imports
199a2cb
add msg signer option to the tx proto messages
e52af75
Merge remote-tracking branch 'origin/main' into feat/sdk-v0.50
70f5e86 
# Conflicts:
#	ignite/templates/app/files/app/encoding.go.plush
#	ignite/templates/app/files/app/params/encoding.go.plush
#	ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/root.go.plush
#	ignite/templates/testutil/files/testutil/network/network.go.plush
add release branch to trigger tests
2bdb1c4
remove invalid test case
b31dc57
fix typo
f54c916
Pantani
Pantani requested changes Nov 22, 2023
View reviewed changes
ignite/cmd/generate_pulsar.go Outdated Show resolved Hide resolved
Pantani
Pantani reviewed Nov 22, 2023
View reviewed changes
ignite/templates/ibc/oracle.go Outdated Show resolved Hide resolved
ignite/templates/module/create/files/base/x/{{moduleName}}/module/autocli.go.plush Outdated Show resolved Hide resolved
ignite/templates/module/create/files/base/x/{{moduleName}}/module/autocli.go.plush Outdated Show resolved Hide resolved
ignite/templates/typed/list/list.go Outdated Show resolved Hide resolved
ignite/templates/typed/list/list.go Outdated Show resolved Hide resolved
ignite/templates/typed/map/map.go Outdated Show resolved Hide resolved
ignite/templates/typed/map/map.go Outdated Show resolved Hide resolved
ignite/templates/typed/singleton/singleton.go Outdated Show resolved Hide resolved
@Pantani
Copy link
Collaborator

Pantani commented Nov 22, 2023

IMHO, removing the blank spaces between commands is more clear. wdyt?

@Pantani Pantani self-requested a review November 22, 2023 15:06
Pantani
Pantani previously approved these changes Nov 24, 2023
View reviewed changes
@Pantani Pantani self-requested a review November 24, 2023 13:16
Pantani
Pantani previously approved these changes Nov 24, 2023
View reviewed changes
@Pantani
Copy link
Collaborator

Pantani commented Nov 24, 2023

There is something weird happening in the CI lint. But running local is ok

@julienrbrt julienrbrt enabled auto-merge (squash) November 24, 2023 13:49
@max-hontar
Copy link
Contributor

There is something weird happening in the CI lint. But running local is ok

For me, local execution throw a lot of messages about "string XXX has X occurances, make a const" and 1 message about format

ignite/templates/ibc/packet.go:364                    gofumpt  File is not `gofumpt`-ed

This line related to file permission and propose to replace 0644 with 0o644

@julienrbrt
Copy link
Member Author

julienrbrt commented Nov 24, 2023 •
edited
Loading

This line related to file permission and propose to replace 0644 with 0o644

I have run make lint-fix which now fixes this.
goconst is a bit too pedantic, the scaffolding needs a big overhaul, but creating constant will make it more unreadable.

EDIT: It seems like goconst messages are just warnings and don't make the lint job fail, now everything is green.

@julienrbrt julienrbrt merged commit 6196635 into main Nov 25, 2023
26 checks passed
@julienrbrt julienrbrt deleted the julien/autocli branch November 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@Pantani Pantani Pantani approved these changes

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates pr:DNM Do not merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AutoCLI
6 participants
@julienrbrt @Pantani @max-hontar @ilgooz @salmad3 @jeronimoalbi