chore: rename go.mod and imports to v29 #3945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:docs
|
Visit the preview URL for this PR (updated for commit 77fde95): https://igntservices-docs--pr3945-julien-v29-b7vbijda.web.app (expires Wed, 27 Mar 2024 09:32:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
julienrbrt
force-pushed
the
julien/v29
branch
from
3f043dc
to
2e2cea4
Compare
julienrbrt
requested review from
salmad3,
toschdev,
ilgooz,
jeronimoalbi and
Pantani
as code owners
|
Actually, I think we want people to open the latest release on gitpod, so linking unreleased v29 doesn't really make sense imho, as v29 is sort of nightly. |
Merged
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
ref: #3945 (comment) Ignite is available on Homebrew (Linux + macOS): https://formulae.brew.sh/formula/ignite#default And the snap store (Linux): https://snapcraft.io/ignite We have CI configured already to publish releases for both of them. I as well added the Flatpak support, but it is harder to release automatically, and we already have two packages managers for linux. Imho we should just remove it.
mergify bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
ref: #3945 (comment) Ignite is available on Homebrew (Linux + macOS): https://formulae.brew.sh/formula/ignite#default And the snap store (Linux): https://snapcraft.io/ignite We have CI configured already to publish releases for both of them. I as well added the Flatpak support, but it is harder to release automatically, and we already have two packages managers for linux. Imho we should just remove it. (cherry picked from commit 97b8c24)
salmad3
pushed a commit
that referenced
this pull request
Mar 12, 2024
ref: #3945 (comment) Ignite is available on Homebrew (Linux + macOS): https://formulae.brew.sh/formula/ignite#default And the snap store (Linux): https://snapcraft.io/ignite We have CI configured already to publish releases for both of them. I as well added the Flatpak support, but it is harder to release automatically, and we already have two packages managers for linux. Imho we should just remove it. (cherry picked from commit 97b8c24) Co-authored-by: Julien Robert <[email protected]>
jeronimoalbi
previously approved these changes
Mar 12, 2024
Pantani
previously approved these changes
Mar 19, 2024
|
we need to rename the consumer changes as well |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3945 +/- ##
==========================================
- Coverage 25.98% 25.97% -0.02%
==========================================
Files 304 304
Lines 25524 25528 +4
==========================================
- Hits 6632 6630 -2
- Misses 18316 18321 +5
- Partials 576 577 +1
|
jeronimoalbi
approved these changes
Mar 20, 2024
toschdev
approved these changes
Mar 20, 2024
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
ref: #3945 (comment) Ignite is available on Homebrew (Linux + macOS): https://formulae.brew.sh/formula/ignite#default And the snap store (Linux): https://snapcraft.io/ignite We have CI configured already to publish releases for both of them. I as well added the Flatpak support, but it is harder to release automatically, and we already have two packages managers for linux. Imho we should just remove it.
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.