Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix the relayer for the ibc guides #4214

Merged
merged 22 commits into from
Sep 6, 2024
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jun 26, 2024

needs #4216

@Pantani Pantani self-assigned this Jun 26, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:configs labels Jun 26, 2024
@Pantani Pantani changed the title fix(docs): fix the realayer for the ibc guides fix(docs): fix the relayer for the ibc guides Jun 26, 2024
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Jun 26, 2024
Copy link
Contributor

github-actions bot commented Jun 26, 2024

Visit the preview URL for this PR (updated for commit bf3556f):

https://igntservices-docs--pr4214-fix-ibc-guides-wucczvbn.web.app

(expires Fri, 13 Sep 2024 10:16:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@Pantani Pantani marked this pull request as draft June 27, 2024 09:23
@Pantani
Copy link
Collaborator Author

Pantani commented Jun 27, 2024

@toschdev I found some issues into the command and the relayer app, let me check first

@Pantani Pantani requested a review from toschdev June 27, 2024 09:50
@Pantani Pantani marked this pull request as ready for review June 27, 2024 09:50
@Pantani Pantani marked this pull request as draft June 27, 2024 09:52
@Pantani Pantani marked this pull request as ready for review June 27, 2024 22:01
@toschdev
Copy link
Contributor

toschdev commented Jul 1, 2024

Still getting a lot of errors trying to run this guide. I've built Ignite CLI from main but am seeing these errors still, what am I missing?

  ../../x/blog/keeper/ibc_post.go:86:11: k.TimeoutPost undefined (type Keeper has     
  no field or method TimeoutPost)                                                     
  ../../x/blog/keeper/ibc_post.go:87:9: undefined: types.TimeoutPost                  
  ../../x/blog/keeper/msg_server_ibc_post.go:14:17: k.addressCodec undefined (type    
  msgServer has no field or method addressCodec)                                      
  ../../x/blog/keeper/msg_server_ibc_post.go:15:15: undefined: errorsmod              
  ../../x/blog/keeper/msg_server_ibc_post.go:15:30: undefined: sdkerrors              
  ../../x/blog/keeper/msg_server_ibc_post.go:15:30: too many errors

@Pantani
Copy link
Collaborator Author

Pantani commented Jul 1, 2024

Still getting a lot of errors trying to run this guide. I've built Ignite CLI from main but am seeing these errors still, what am I missing?

  ../../x/blog/keeper/ibc_post.go:86:11: k.TimeoutPost undefined (type Keeper has     
  no field or method TimeoutPost)                                                     
  ../../x/blog/keeper/ibc_post.go:87:9: undefined: types.TimeoutPost                  
  ../../x/blog/keeper/msg_server_ibc_post.go:14:17: k.addressCodec undefined (type    
  msgServer has no field or method addressCodec)                                      
  ../../x/blog/keeper/msg_server_ibc_post.go:15:15: undefined: errorsmod              
  ../../x/blog/keeper/msg_server_ibc_post.go:15:30: undefined: sdkerrors              
  ../../x/blog/keeper/msg_server_ibc_post.go:15:30: too many errors

The docs had some typos, which have been fixed now. And you need to use the Hermes app from this branch

@salmad3
Copy link
Member

salmad3 commented Aug 23, 2024

Able to revisit?

@Pantani
Copy link
Collaborator Author

Pantani commented Sep 5, 2024

Able to revisit?

@toschdev can we merge this one?

@toschdev
Copy link
Contributor

toschdev commented Sep 5, 2024

Yes let's go

@julienrbrt julienrbrt enabled auto-merge (squash) September 6, 2024 10:16
@julienrbrt julienrbrt merged commit 970956a into main Sep 6, 2024
43 of 47 checks passed
@julienrbrt julienrbrt deleted the fix/ibc-guides branch September 6, 2024 10:25
@julienrbrt
Copy link
Member

@mergify backport release/v28.x.y

Copy link
Contributor

mergify bot commented Sep 6, 2024

backport release/v28.x.y

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 6, 2024
* fix the realayer for the ibc guides

* fix chain-id

* fix port-id for ibc transfers

* fix channel version

* fix blog ibc guide for use collections

* fix typo into the parameters and set postid to uint

* remove unused comments

---------

Co-authored-by: Danny <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 970956a)
julienrbrt pushed a commit that referenced this pull request Sep 8, 2024
* fix the realayer for the ibc guides

* fix chain-id

* fix port-id for ibc transfers

* fix channel version

* fix blog ibc guide for use collections

* fix typo into the parameters and set postid to uint

* remove unused comments

---------

Co-authored-by: Danny <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 970956a)

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:docs Documentation additions or improvements. skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants