-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge the swagger files manually instead use nodetime swagger-combine
(backport #4077)
#4225
Conversation
…combine` (#4077) * merge the Swagger files manually instead use nodejs swagger-combine * add changelog * remove unused function vars * remove unused error handler --------- Co-authored-by: Pantani <Pantani> (cherry picked from commit 6de2f33) # Conflicts: # go.mod # go.sum # ignite/pkg/cosmosgen/generate_openapi.go # ignite/pkg/nodetime/programs/swagger-combine/swagger-combine.go
Cherry-pick of 6de2f33 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
# Conflicts: # go.mod # go.sum # integration/doctor/testdata/missing-tools.go.txt
Visit the preview URL for this PR (updated for commit c8f5ab3): https://igntservices-docs--pr4225-mergify-bp-release-v-t284sgfz.web.app (expires Wed, 17 Jul 2024 00:55:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5 |
…/release/v28.x.y/pr-4077 # Conflicts: # ignite/pkg/cosmosgen/generate_openapi.go # ignite/templates/app/files/go.mod.plush
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! It even fixes a bug in v28 💪🏾
Description
This PR changes the package swagger-combine to merge all swagger files into the code instead of using the NodeJs pkg
swagger-combine
inside the nodetime binary.How to test
This is an automatic backport of pull request feat: merge the swagger files manually instead use nodetime
swagger-combine
#4077 done by Mergify.