Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): only panics the module in the most top function level #4300

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 13, 2024

Description

Avoid using a lot of panic calls into the InitGenesis and ExportGenesis methods and panic in the parent function. This also make the code more testable.

@Pantani Pantani self-assigned this Aug 13, 2024
@Pantani Pantani marked this pull request as draft August 13, 2024 14:01
@Pantani Pantani changed the title feat(template): only panics in the most top function level feat(template): only panics the module in the most top function level Aug 13, 2024
@Pantani Pantani marked this pull request as ready for review August 13, 2024 18:29
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes better 👍🏾

@mergify mergify bot merged commit d1305ea into main Aug 13, 2024
47 of 48 checks passed
@mergify mergify bot deleted the feat/panic-on-module branch August 13, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants