Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix chain id for chain simulations #4309

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix: fix chain id for chain simulations #4309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5112c5f
fix chain id for simulations
Pantani Aug 21, 2024
b67e038
add changelog
Pantani Aug 21, 2024
e131237
Merge branch 'main' into fix/simulation-chainid
Pantani Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
- [#4000](https://github.com/ignite/cli/pull/4000) Run all dry runners before the wet run in the `xgenny` pkg
- [#4091](https://github.com/ignite/cli/pull/4091) Fix race conditions in the plugin logic
- [#4128](https://github.com/ignite/cli/pull/4128) Check for duplicate proto fields in config
- [#4309](https://github.com/ignite/cli/pull/4309) Fix chain id for chain simulations

## [`v28.5.1`](https://github.com/ignite/cli/releases/tag/v28.5.1)

Expand Down
5 changes: 2 additions & 3 deletions ignite/templates/app/files/app/sim_test.go.plush
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ func TestAppStateDeterminism(t *testing.T) {
config.ExportParamsPath = ""
config.OnOperation = true
config.AllInvariants = true
config.ChainID = SimAppChainID

numSeeds := 3
numTimesToRunPerSeed := 3 // This used to be set to 5, but we've temporarily reduced it to 3 for the sake of faster CI.
Expand Down Expand Up @@ -372,8 +373,6 @@ func TestAppStateDeterminism(t *testing.T) {
} else {
logger = log.NewNopLogger()
}
chainID := fmt.Sprintf("chain-id-%d-%d", i, j)
config.ChainID = chainID

db := dbm.NewMemDB()
bApp, err := app.New(
Expand All @@ -383,7 +382,7 @@ func TestAppStateDeterminism(t *testing.T) {
true,
appOptions,
interBlockCacheOpt(),
baseapp.SetChainID(chainID),
baseapp.SetChainID(SimAppChainID),
)
require.NoError(t, err)

Expand Down
Loading