fix(analytics): check do not track (backport #4329) #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Our do not track check was wrong and always returning true. This is why we were getting nothing. (cherry picked from commit e04d0f6)
mergify
bot
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
julienrbrt
approved these changes
Aug 29, 2024
Pantani
approved these changes
Aug 29, 2024
salmad3
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our do not track check was wrong and always returning true.
This is why we were getting nothing.
This is an automatic backport of pull request #4329 done by Mergify.