Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): missed condition #4336

Merged
merged 5 commits into from
Sep 3, 2024
Merged

fix(ci): missed condition #4336

merged 5 commits into from
Sep 3, 2024

Conversation

julienrbrt
Copy link
Member

Follow-up of #4334

@julienrbrt julienrbrt enabled auto-merge (squash) August 30, 2024 21:57
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Aug 30, 2024
@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Aug 30, 2024
Pantani
Pantani previously approved these changes Aug 30, 2024
salmad3
salmad3 previously approved these changes Aug 31, 2024
@julienrbrt
Copy link
Member Author

Looks like it surfaced some broken tests. I'll check

@julienrbrt
Copy link
Member Author

So weird it passes for me locally (!)

@julienrbrt
Copy link
Member Author

julienrbrt commented Sep 3, 2024

Even with act it passes 🤯

image

@julienrbrt julienrbrt merged commit 35b9a26 into main Sep 3, 2024
42 of 45 checks passed
@julienrbrt julienrbrt deleted the julien/ci branch September 3, 2024 08:06
julienrbrt added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs skip-changelog Don't check changelog for new entries type:internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants