fix: comment out optimistic execution #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
faddat
changed the title
julienrbrt
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I do think it makes sense to have OE as an easy to access option, I also have learned recently that OE can cause problems when using VE.
The goal of this change is to make ignite as smooth as possible for its users.
Context: Just spent 2 days trying to figure out why VE wouldn't work :).
So my proposed solution is to comment it out in the template so that it can be easily re-enabled.