OF-2916 and OF-2917 Add the option to control MUC history preservation #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 26, 2024 13:48
…cRoom table creation scripts. This new field determines whether a room's chat history is preserved or removed upon its deletion.
…eHistOnRoomDeletion field.[C
…e MUCRoom class so it can be accessed during runtime.
…r to use the new preserveHistOnRoomDeletion field for processing room configuration.
…Manager to load and store room settings and history, incorporating the new preserveHistOnRoomDeletion field. 2. Add functionality to remove room history stored in ofMucConversationLog upon room deletion. 3. Add the new preserveHistOnRoomDeletion field to the MUC default room settings screen, as well as to the room edit and creation screens.
guusdk
requested changes
Nov 26, 2024
xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/IQOwnerHandler.java
Outdated
Show resolved
Hide resolved
MUCPersistenceManager was changed to make use of the chat history preservation setting. Is this what you are asking about? |
added 2 commits
November 27, 2024 14:51
Add a preserveHistOnDel field to the OfMucRoom table to specify chat history preservation on the deletion of a chat room. Updated MUCPersistenceManager to make use of the new preserveHistOnDel field.
Changing muc#roomconfig_preservehistondel to {http://igniterealtime.org}muc#roomconfig_preservehistondel as it is a third party field.
Yes it was - I had not spotted that when I did the review. There's also an in-memory history object |
guusdk
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.