Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve certificate revocation checking #2626

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Commits on Nov 28, 2024

  1. fix: Improve certificate revocation checking

    Configure PKIXRevocationChecker to only check end-entity certificates and
    use soft-fail for unavailable revocation information.
    
    This attempts to balance security and reliability:
    - Focusing revocation checks on leaf certificates, where revocation is most critical, avoiding issues with missing root certificate CRL distribution points
    - Preventing validation failures when OCSP/CRL servers are unreachable or when revocation information isn't available for some certificates
    - Avoiding common issues with intermediate/root certificate CRL checking
    viv committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3915592 View commit details
    Browse the repository at this point in the history
  2. feat: provide control over revocation checking

    Allow administrators to configure revocation checking behaviour. If Openfire is operating in a closed, tightly controlled network, an administrator can reconfigure the balance between security and reliability.
    viv committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a3b3ced View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    995797e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. fix: Enable downloading of CRL info

    Configure Java and BouncyCastle to enable CRL Distribution Points (CRLDP) checking.
    
    Openfire will now attempt to download CRLs from the URLs specified in the certificate's CRL Distribution Points extension, regardless of whether it's using BC or the Java built-in certificate validation.
    viv committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2c2b5cb View commit details
    Browse the repository at this point in the history
  2. docs: Clarify revocation options

    viv committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6ea5328 View commit details
    Browse the repository at this point in the history
  3. fix: Use tighter revocation checking options

    Tightening up the default revocation checking config now that we can check revocation status of intermediate certificates via CRLDPs.
    viv committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c468343 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d068d79 View commit details
    Browse the repository at this point in the history