-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve certificate revocation checking #2626
Open
viv
wants to merge
7
commits into
igniterealtime:main
Choose a base branch
from
surevine:configure-revocation-checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+72
−2
Commits on Nov 28, 2024
-
fix: Improve certificate revocation checking
Configure PKIXRevocationChecker to only check end-entity certificates and use soft-fail for unavailable revocation information. This attempts to balance security and reliability: - Focusing revocation checks on leaf certificates, where revocation is most critical, avoiding issues with missing root certificate CRL distribution points - Preventing validation failures when OCSP/CRL servers are unreachable or when revocation information isn't available for some certificates - Avoiding common issues with intermediate/root certificate CRL checking
Configuration menu - View commit details
-
Copy full SHA for 3915592 - Browse repository at this point
Copy the full SHA 3915592View commit details -
feat: provide control over revocation checking
Allow administrators to configure revocation checking behaviour. If Openfire is operating in a closed, tightly controlled network, an administrator can reconfigure the balance between security and reliability.
Configuration menu - View commit details
-
Copy full SHA for a3b3ced - Browse repository at this point
Copy the full SHA a3b3cedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 995797e - Browse repository at this point
Copy the full SHA 995797eView commit details
Commits on Dec 2, 2024
-
fix: Enable downloading of CRL info
Configure Java and BouncyCastle to enable CRL Distribution Points (CRLDP) checking. Openfire will now attempt to download CRLs from the URLs specified in the certificate's CRL Distribution Points extension, regardless of whether it's using BC or the Java built-in certificate validation.
Configuration menu - View commit details
-
Copy full SHA for 2c2b5cb - Browse repository at this point
Copy the full SHA 2c2b5cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ea5328 - Browse repository at this point
Copy the full SHA 6ea5328View commit details -
fix: Use tighter revocation checking options
Tightening up the default revocation checking config now that we can check revocation status of intermediate certificates via CRLDPs.
Configuration menu - View commit details
-
Copy full SHA for c468343 - Browse repository at this point
Copy the full SHA c468343View commit details -
Configuration menu - View commit details
-
Copy full SHA for d068d79 - Browse repository at this point
Copy the full SHA d068d79View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.