[sinttest] Add roster tests that are driven by presence stanzas #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
SINT_roster-presence-based
branch
8 times, most recently
from
eab7e2d
to
8e22349
Compare
guusdk
force-pushed
the
SINT_roster-presence-based
branch
from
c9cdeb5
to
ec787f2
Compare
|
This PR didn't have any apparant successful CI runs. I've rebased it to the current head of the master branch, which caused a run to start (and succeed). |
guusdk
force-pushed
the
SINT_roster-presence-based
branch
from
ec787f2
to
a3c55cb
Compare
|
I've rebased this PR, to take in the latest new features available in Smack. Those have been applied to the new tests (eg: the tagging with specification references). @Flowdalic provided feedback on this commit over IM, which has also been applied. |
|
Note that Openfire 4.8.1. appears to have a bug that causes one of the tests added in this PR to fail: https://igniterealtime.atlassian.net/browse/OF-2822 |
guusdk
force-pushed
the
SINT_roster-presence-based
branch
2 times, most recently
from
4a406d6
to
3062dc1
Compare
guusdk
changed the title
Flowdalic
requested changes
Apr 20, 2024
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
smack-integration-test/src/main/java/org/jivesoftware/smack/roster/RosterIntegrationTest.java
Outdated
Show resolved
Hide resolved
|
LGTM, squash please |
RFC-6121 defines server-sided behavior of the interaction between presence stanzas and rosters. This commit adds tests for that behavior.
The implementation of the test that is being removed depends on a server characteristic that will cause a loop of presence stanzas (which obviously is bad). A RFC3921-compliant client can send an 'acknowledgement' after receiving a presence 'subscribed' stanza, in the form of a presence 'subscribe' stanza. See section 8.2 of RFC3921. When a server implementation does not ignore this acknowledgement, the domain of the recipient MUST (RFC6121 section 3.1.3) respond with a 'subscribed' on behalf of the recipient (which is what the now removed test was verifying). This can trigger the RFC3921-compliant sender to again receive 'subscribed', that it again can acknowledge, which causes a loop. To test RFC6121, the subscription state of the recipient must somehow be modified to reflect a different state than that of the initiator. I'm not sure if that is feasible with the SINT framework.
guusdk
force-pushed
the
SINT_roster-presence-based
branch
from
253d469
to
ad75681
Compare
|
Squashed. I've left the removal of one test as a distinct commit, as the commit message documents the rationale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC-6121 defines server-sided behavior of the interaction between presence stanzas and rosters.
This commit adds tests for that behavior.