Improve handling of expanded Websocket 'open' element #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this fix, Smack requires the 'open' element send on a websocket connection to be collapsed. With the change in this commit, an expanded (eg: `<open ...></open>`) element can also be used. fixes SMACK-935
guusdk
force-pushed
the
SMACK-935_Websocket-open-element
branch
from
40f10b1
to
6244a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, Smack requires the 'open' element send on a websocket connection to be collapsed. With the change in this commit, an expanded (eg:
<open ...></open>) element can also be used.fixes SMACK-935