SPARK-2338 Refactor: rename the confusing "Old SSL" to "Direct TLS" #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses a term "Old SSL" for Direct TLS connections on port 5223.
This is supported by XEP-0368 and may be not necessary for old clients.
To make the code follow same terminology as XEP I renamed the LocalPreferences.isSSL() to isDirectTls(). The property name in properties file internally remains same.
Additionally extract the similar code to configure TLS in the Login and AccountCreationWizard.