ci: test tox-docker #205
Closed
ci: test tox-docker #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds a new job to the CI workflow to test using tox-docker. The changes are implemented by modifying the .github/workflows/ci.yml file to include a new job that runs after the pylint job. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @cesarcoatl - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -16,3 +16,7 @@ jobs: | |||
| pylint: | |||
| needs: pre-commit | |||
| uses: coatl-dev/workflows/.github/workflows/pylint.yml@v3 | |||
|
|
|||
| tox: | |||
There was a problem hiding this comment.
suggestion: Consider adding a description for the tox job.
Adding a description for the tox job can help other developers understand its purpose and functionality at a glance.
Suggested change
| tox: | |
| tox: | |
| description: "Run tests using tox and Docker" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request updates the CI workflow to include a new job for running tests with tox-docker, ensuring compatibility and proper testing within Docker containers.