Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to flake #12

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

AlexSherbinin
Copy link
Contributor

  • Introduced Rust build support using Nix's flake.
  • Implemented checks for stable, beta, and nightly toolchain channels. These checks include: cargo-nextest for parallel testing (replacing cargo test), clippy for linting, and fmt for formatting check.
  • Added a CI workflow to update the Rust version in flake.lock.

@igordejanovic
Copy link
Owner

Thanks. I tried this config today and just can't get it to work. Please see nix-build branch. Command nix flake check runs very long time. Actually, couldn't wait for it to finish. It looked like it was running in infinite loop.

Could you take a look?

@igordejanovic
Copy link
Owner

Ah, I figured out that all tests are run for each package (nix flake check -L), that's why it takes extremely long.

@igordejanovic igordejanovic merged commit 1852c27 into igordejanovic:main Jun 10, 2024
1 check failed
@igordejanovic
Copy link
Owner

I think I've resolved all issues. Now, a single derivation with dependencies is built per workspaces, sources are cleaned properly and only one check is done per toolchain/workspace. We could probably optimize the CI pipeline further but it finish in reasonable time. I would also like to add code coverage and advisory-db check but I think that would be now much easier to do.

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants