Fix support of relative urls in createJsonQuery and `createJsonMuta…

…tion`

.changeset/light-jars-destroy.md

@@ -0,0 +1,5 @@
+---
+"@farfetched/core": patch
+---
+
+Fix support of relative urls in `createJsonQuery` and `createJsonMutation`

packages/core/src/__tests__/relative_urls_in_jsdom.test.ts

@@ -0,0 +1,54 @@
+/**
+ * @vitest-environment jsdom
+ */
+import { describe, test, expect } from 'vitest';
+import { allSettled, fork } from 'effector';
+
+import { createJsonQuery } from '../query/create_json_query';
+import { unknownContract } from '../contract/unknown_contract';
+import { fetchFx } from '../fetch/fetch';
+
+describe('relative paths in createJsonQuery, issue #493', () => {
+  test('does not throw error for valid relative path', async () => {
+    const query = createJsonQuery({
+      request: { url: '/api', method: 'GET' },
+      response: { contract: unknownContract },
+    });
+
+    const scope = fork({
+      // We have to to mock fetchFx, because URL validation embed in createJsonQuery.__.executeFx
+      handlers: [[fetchFx, () => new Response(JSON.stringify('DATA'))]],
+    });
+
+    await allSettled(query.start, { scope });
+
+    expect(scope.getState(query.$error)).toBe(null);
+    expect(scope.getState(query.$data)).toBe('DATA');
+  });
+
+  test('does throw error for invalid relative path', async () => {
+    const query = createJsonQuery({
+      request: { url: 'api **** jkjj', method: 'GET' },
+      response: { contract: unknownContract },
+    });
+
+    const scope = fork({
+      // We have to to mock fetchFx, because URL validation embed in createJsonQuery.__.executeFx
+      handlers: [[fetchFx, () => new Response(JSON.stringify('DATA'))]],
+    });
+
+    await allSettled(query.start, { scope });
+
+    expect(scope.getState(query.$error)).toMatchInlineSnapshot(`
+      {
+        "errorType": "CONFIGURATION",
+        "explanation": "Operation is misconfigured",
+        "reason": "Invalid URL",
+        "validationErrors": [
+          ""api **** jkjj" is not valid URL",
+        ],
+      }
+    `);
+    expect(scope.getState(query.$data)).toBe(null);
+  });
+});

packages/core/src/fetch/lib.ts

@@ -73,6 +73,11 @@ export function formatUrl(
   url: string,
   queryRecord: FetchApiRecord | string
 ): URL {
+  let urlBase: string | undefined;
+  if (url.startsWith('/')) {
+    urlBase = window.location.origin;
+  }
+
   let urlString: string;
   let queryString: string;
 
@@ -89,7 +94,7 @@ export function formatUrl(
   }
 
   try {
-    return new URL(urlString);
+    return new URL(urlString, urlBase);
   } catch (e) {
     throw configurationError({
       reason: 'Invalid URL',