Update NotificationItem.jsx #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove of the height reset on render. This fixes the height of the notification, and prevents having dynamic children (with variable height) to be displayed properly. Should also help in closing igorprado#77.
Moving the call to onAdd, in the callback of setState
|
Also moved the call to onAdd in the callback of the setState |
|
What's the status of this? |
|
Waiting for PR acceptation, and new release of the PR is or for you.
…On Wed, 10 May 2017, 19:17 Steven Silvestri, ***@***.***> wrote:
What's the status of this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjEjNFB-Piyr3TFpnSVfk2Wn9fTa4HIks5r4fE4gaJpZM4M-YPB>
.
|
|
Any update on this? @igorprado |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove of the height reset on render.
This fixes the height of the notification, and prevents having dynamic children (with variable height) to be displayed properly.
Should also help in closing #77.