refactor: forward get.adjacency.dense() to get.adjacency.sparse() if attributes are present (#1483)

[schochastics]

This PR removes (nested) for loops for get.adjacency.dense() when attr != NULL

(cherry picked commits from #1518)

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[schochastics]

Test fails because tests in main are currently not correct, see #1551 (and also #1518). Should the tests be fixed here?

cc @maelle @krlmlr

[krlmlr]

Every PR should be green, yes. If this needs changing tests, it can be done in the same PR.

The best would be to change tests first, in a separate commit or PR, so that they work both with the existing and the new implementation. Not sure if it's worth the effort.

[krlmlr]

Thanks, great! Somehow dimnames() are lost in R 4.1 and earlier, the checks are failing.

[schochastics]

Ready to be reviewed again

[krlmlr]

Thanks, we're close.

[schochastics]

ready again