Split response fix #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one packet contains exactly the declared data size, but not the line terminator chars, then they will not be consumed and will block consumption of further commands
There was miscounting in the consuming of the bodies when the associated line terminator did not turn up in the same delivery. Removed the check on the return value of the `handle` methods. They duplicate the check made in `handles?` and nothing is ever passed to `handle` without first being tested in `handles?`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not handle case where packet boundaries split a body from its line terminator exactly. Line terminator not consumed, nor anything past it. For example:
Considerably simplified multi-packet reading and body-extraction logic.