Add new adapter for ActiveRecord 4.2, fix #198 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exAspArk
force-pushed
the
activerecord_4.2
branch
from
efbceec to
adfc880
Compare
| @@ -11,7 +11,7 @@ group :development do | |||
| gem 'activerecord', "= #{ENV['activerecord'] || '4.1.8'}" | |||
| gem 'em-mongo' | |||
| gem 'bson_ext' | |||
| gem 'mysql2' | |||
There was a problem hiding this comment.
Any reason why you're freezing the version?
There was a problem hiding this comment.
I'm not sure why, but it failed to load an adapter https://travis-ci.org/igrigorik/em-synchrony/builds/102289375:
Specified 'em_mysql2' for database adapter, but the gem is not loaded. Add `gem 'mysql2'` to your Gemfile.
Probably, it is related to the issue rails/rails#21544 (found it here). This fix rails/rails@5da5e37 hasn't been released yet.
There was a problem hiding this comment.
Opened a separate PR #203 for it
|
@igrigorik hello! why you don't like an original MonitorMixin approach? |
Related: * NullTransaction rails/rails@057c237 * TransactionManager rails/rails@97bb76d
exAspArk
force-pushed
the
activerecord_4.2
branch
from
adfc880 to
7a9f802
Compare
igrigorik
added a commit
that referenced
this pull request
Mar 4, 2016
Add new adapter for ActiveRecord 4.2, fix #198
|
\o/ ... thank you for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another try to add support for ActiveRecord 4.2 and fix #198.
It just adds a new adapter by replacing
ClosedTransactionwithNullTransactionand usingActiveRecord::ConnectionAdapters::TransactionManager. Generally it keeps the same behavior.There is also another PR #190 which changes
MonitorMixinto add fiber aware support.