Skip to content

Commit

Permalink
github: Don't run scheduled workflows on forks.
Browse files Browse the repository at this point in the history
It is annoying to have scheduled workflows running on your own fork,
especially if there are flaky tests or the workflow is broken and
permanently failing for an extended period of time generating an email
for every failure every week.

GitHub doesn't allow to selectively disable triggers, workflow can
only be disabled as a whole, so developers need to keep these failing
workflows running if they want to test their own changes before
submitting patches.

These scheduled workflows have little value on typical forks, i.e. the
ones that are not actual forks with custom code but forks for the
purpose of testing code before sending patches upstream.  Real forks
have code changes already, and they are free to modify the workflows
if they want the scheduled ones.

Signed-off-by: Ilya Maximets <[email protected]>
  • Loading branch information
igsilya committed Jul 29, 2024
1 parent f2363f4 commit 0970551
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/containers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ env:

jobs:
container:
if: github.repository_owner == env.IMAGE_NAMESPACE
runs-on: ubuntu-24.04
strategy:
matrix:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ovn-fake-multinode-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ concurrency:
jobs:
build:
name: Build ovn-fake-multinode image
if: github.repository_owner == 'ovn-org' || github.event_name != 'schedule'
runs-on: ubuntu-22.04
strategy:
matrix:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ovn-kubernetes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ env:
jobs:
build:
name: Build
if: github.repository_owner == 'ovn-org' || github.event_name != 'schedule'
runs-on: ubuntu-22.04
steps:
- name: Enable Docker experimental features
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
env:
DEPENDENCIES: podman
name: Prepare container
if: github.repository_owner == 'ovn-org' || github.event_name != 'schedule'
runs-on: ubuntu-24.04

steps:
Expand Down Expand Up @@ -186,6 +187,7 @@ jobs:
OPTS: --disable-ssl

name: osx clang --disable-ssl
if: github.repository_owner == 'ovn-org' || github.event_name != 'schedule'
runs-on: macos-latest

strategy:
Expand Down Expand Up @@ -240,6 +242,7 @@ jobs:

build-linux-rpm:
name: linux rpm fedora
if: github.repository_owner == 'ovn-org' || github.event_name != 'schedule'
runs-on: ubuntu-22.04
container: fedora:40
timeout-minutes: 30
Expand Down

0 comments on commit 0970551

Please sign in to comment.