Skip to content

Commit

Permalink
tests: Fix flaky ACL Sampling system tests.
Browse files Browse the repository at this point in the history
Waiting for "ovs-ofctl dump-ipfix-flow br-int | grep -q '1 ids'" does
not guarantee that sampling related flows are installed in OVS.

Fixes: d15b12d ("northd: Add ACL Sampling.")
Signed-off-by: Xavier Simonart <[email protected]>
Acked-by: Mark Michelson <[email protected]>
Signed-off-by: Mark Michelson <[email protected]>
  • Loading branch information
simonartxavier authored and putnopvut committed Sep 11, 2024
1 parent d81738a commit 55e270f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/system-ovn.at
Original file line number Diff line number Diff line change
Expand Up @@ -13165,6 +13165,7 @@ ovs-vsctl --id=@br get Bridge br-int \
-- --id=@ipfix create IPFIX targets=\"127.0.0.1:4242\" template_interval=1 \
-- --id=@cs create Flow_Sample_Collector_Set id=100 bridge=@br ipfix=@ipfix

ovn-nbctl --wait=hv sync
dnl And wait for it to be up and running.
OVS_WAIT_UNTIL([ovs-ofctl dump-ipfix-flow br-int | grep -q '1 ids'])

Expand Down Expand Up @@ -13333,6 +13334,7 @@ ovs-vsctl --id=@br get Bridge br-int \
-- --id=@ipfix create IPFIX targets=\"127.0.0.1:4242\" template_interval=1 \
-- --id=@cs create Flow_Sample_Collector_Set id=100 bridge=@br ipfix=@ipfix

ovn-nbctl --wait=hv sync
dnl And wait for it to be up and running.
OVS_WAIT_UNTIL([ovs-ofctl dump-ipfix-flow br-int | grep -q '1 ids'])

Expand Down Expand Up @@ -13462,6 +13464,7 @@ ovs-vsctl --id=@br get Bridge br-int \
-- --id=@ipfix create IPFIX targets=\"127.0.0.1:4242\" template_interval=1 \
-- --id=@cs create Flow_Sample_Collector_Set id=100 bridge=@br ipfix=@ipfix

ovn-nbctl --wait=hv sync
dnl And wait for it to be up and running.
OVS_WAIT_UNTIL([ovs-ofctl dump-ipfix-flow br-int | grep -q '1 ids'])

Expand Down

0 comments on commit 55e270f

Please sign in to comment.