xjc generation changes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvertdw
reviewed
Nov 18, 2024
cppbuild.bash
Outdated
| ' "$file" | ||
|
|
||
| # Delete the Generated on: line so we don't constantly have new vcs changes to these files | ||
| sed -i '/\/\/ Generated on:/d' "$file" |
calvertdw
reviewed
Nov 18, 2024
calvertdw
reviewed
Nov 18, 2024
| file(dest).mkdirs() | ||
| fun runScript(scriptPath: String, envVars: Map<String, String> = emptyMap(), vararg args: String) { | ||
| val isWindows = System.getProperty("os.name").lowercase().contains("win") | ||
| val bashCommand = if (isWindows) "C:\\Program Files\\Git\\git-bash.exe" else "bash" |
There was a problem hiding this comment.
Wouldn't it be more reliable to write a powershell?
There was a problem hiding this comment.
No, because bash is not available on the default Path
calvertdw
approved these changes
Nov 18, 2024
TomaszTB
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xjc, I found this to be less flaky overall. It will not run if xjc is not available on the system.