chore(angular): v17 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbalet please open a PR where you just make the changes needed for angular 17 to work. |
|
@ihym I can do, would you also like me to do the fixes in a separate pull-request? And if I would open an issue for prettierc would you accept it? (I would do this one first then, because it make the life whole lot easier) |
|
Yes, open a separate PR. Dont open another issue. |
|
Close: Will do separate commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
enlanguageempty strings.numbers-> Due to new typescript compilation errorsNote
Due to the .prettierrc, a lot have being changed, to have a better look, see each commit one after the other.
I've created one commit per changes, so that you shall cherry pick if you need.
Related issue
Following shall be closed : #70