-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase "fragment stuck" timeout from 10s to 30s [try to avoid erroneously labeling slow video downloads as "stuck"] #169
Conversation
Fixes many videos failures due to progress polling hanging for some amount of time.
This seems very safe to merge: Is the "cost" a slower UX during downloads, while monitoring the "Tasks" view? |
The cost is real stuck videos will take longer to detect. |
A new VM was created after PR #169 was merged. Another attempt to download the failed video https://www.youtube.com/watch?v=7B_GljX52w8 individually also resulted in download stuck error as shown below suggesting there is a deeper problem with this single video.It however plays well on Youtube. |
@deldesir plz investigate and aim for 100% of videos downloaded 🎯 Or if that's impossible, provide more clear explanations (with a "Googlable" explanation in "Tasks" view) for each of the main kinds of video download failure, allowing every intelligent teacher worldwide to self-empower their community to learn why exactly they're being blocked. 🌱 |
I have shared OpenVpn details with Adam for you to access my machine |
|
Thanks |
root@box:/var/log# pastebinit -b dpaste.com /var/log/calibre-web.log root@box:/var/log# pastebinit -b dpaste.com /var/log/xklb.log |
@EMG70 also needed to configure SSH for incoming connections (recent versions of Ubuntu have tightened security!) as he's now done:
ASIDE: Thanks to PR iiab/iiab#3748, his iiab-diagnostics are now posted here: https://dpaste.com/A93HCTC8J |
@deldesir also requested his |
Thanks @deldesir for confirming! Looks like: As originally discussed here: |
Fixes many videos failures due to progress polling hanging for some amount of time.
Tested on Ubuntu 24.10 (t4) but needs further testing from @EMG70 and others.
Related to #168