Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase "fragment stuck" timeout from 10s to 30s [try to avoid erroneously labeling slow video downloads as "stuck"] #169

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jun 4, 2024

Fixes many videos failures due to progress polling hanging for some amount of time.

Tested on Ubuntu 24.10 (t4) but needs further testing from @EMG70 and others.

Related to #168

Fixes many videos failures due to progress polling hanging for some amount of time.
@deldesir deldesir requested a review from holta June 4, 2024 00:08
@deldesir deldesir self-assigned this Jun 4, 2024
@deldesir deldesir added the bug Something isn't working label Jun 4, 2024
@holta
Copy link
Member

holta commented Jun 4, 2024

This seems very safe to merge:

Is the "cost" a slower UX during downloads, while monitoring the "Tasks" view?

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 4, 2024

The cost is real stuck videos will take longer to detect.

@holta holta merged commit eb83023 into iiab:master Jun 4, 2024
@holta holta changed the title Increase "fragment stuck" timeout to 30s Increase "fragment stuck" timeout from 10s to 30s [try to avoid erroneously labeling stuck video downloads as "stuck"] Jun 4, 2024
@holta holta changed the title Increase "fragment stuck" timeout from 10s to 30s [try to avoid erroneously labeling stuck video downloads as "stuck"] Increase "fragment stuck" timeout from 10s to 30s [try to avoid erroneously labeling slow video downloads as "stuck"] Jun 4, 2024
@EMG70
Copy link

EMG70 commented Jun 4, 2024

A new VM was created after PR #169 was merged.
A huge improvement on stuck /failed downloads .The following pottery playlist https://www.youtube.com/playlist?list=PLbC14Txh1KZdaX5DkYYX8BBF3j9Bowhce previously had many failed downloads but now 29/30 videos downloaded OK after merging 169.
The only failed video https://www.youtube.com/watch?v=7B_GljX52w8 showed that error "Download appears to be stuck" as on screenshot.
Screenshot from 2024-06-04 13-01-58

Another attempt to download the failed video https://www.youtube.com/watch?v=7B_GljX52w8 individually also resulted in download stuck error as shown below suggesting there is a deeper problem with this single video.It however plays well on Youtube.

Screenshot from 2024-06-04 13-11-03

@holta
Copy link
Member

holta commented Jun 4, 2024

The only failed video https://www.youtube.com/watch?v=7B_GljX52w8 showed that error "Download appears to be stuck" as on screenshot.

@deldesir plz investigate and aim for 100% of videos downloaded 🎯

Or if that's impossible, provide more clear explanations (with a "Googlable" explanation in "Tasks" view) for each of the main kinds of video download failure, allowing every intelligent teacher worldwide to self-empower their community to learn why exactly they're being blocked. 🌱

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 4, 2024

Some unknown factors are at play there. Can I get access to the VM where the video failed or at least see the log? T4 tests still "PASS".

image

@EMG70
Copy link

EMG70 commented Jun 4, 2024

I have shared OpenVpn details with Adam for you to access my machine

@holta
Copy link
Member

holta commented Jun 4, 2024

Can I get access to the VM where the video failed or at least see the log?

  1. @EMG70 can you share /var/log/calibre-web.log and /var/log/xklb.log as @deldesir needs? Run the following: (as root of course!)

    pastebinit -b dpaste.com /var/log/calibre-web.log
    pastebinit -b dpaste.com /var/log/xklb.log
    
  2. Could https://youtu.be/7B_GljX52w8 download failures appear to be somewhat random — depending on network traffic congestion at that moment — or some such?

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 4, 2024

I have shared OpenVpn details with Adam for you to access my machine

Thanks

@EMG70
Copy link

EMG70 commented Jun 4, 2024

root@box:/var/log# pastebinit -b dpaste.com /var/log/calibre-web.log
https://dpaste.com/FZ4VBWP85

root@box:/var/log# pastebinit -b dpaste.com /var/log/xklb.log
https://dpaste.com/65S6CDVEW
root@box:/var/log#

@holta
Copy link
Member

holta commented Jun 4, 2024

I have shared OpenVpn details with Adam for you to access my machine

@EMG70 also needed to configure SSH for incoming connections (recent versions of Ubuntu have tightened security!) as he's now done:

sudo -i
rm /etc/ssh/sshd_config.d/60-cloudimg-settings.conf
echo 'PasswordAuthentication yes' >> /etc/ssh/sshd_config
systemctl reload ssh

ASIDE: Thanks to PR iiab/iiab#3748, his iiab-diagnostics are now posted here: https://dpaste.com/A93HCTC8J

@holta
Copy link
Member

holta commented Jun 4, 2024

root@box:/var/log# pastebinit -b dpaste.com /var/log/calibre-web.log https://dpaste.com/FZ4VBWP85

root@box:/var/log# pastebinit -b dpaste.com /var/log/xklb.log https://dpaste.com/65S6CDVEW

@deldesir also requested his /library/calibre-web/xklb-metadata.db so I zipped that up and attached it here:

xklb-metadata.db.zip

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 4, 2024

Thanks @holta and @EMG70, the db file helped. The video downloaded but was not moved to /library/calibre-web.

image

@holta
Copy link
Member

holta commented Jun 4, 2024

video downloaded but was not moved to /library/calibre-web.

Thanks @deldesir for confirming! Looks like:

As originally discussed here:

@deldesir deldesir deleted the deldesir-patch-33 branch July 1, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants