-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set outtmpl externally [to avoid missing thumbnails; NOTE: archival-quality book & video titles are preserved in 2 SQLite db's] #177
Conversation
Is the idea to further strengthen thumbnail resiliency, building on xklb 2.8.059 ? Background — xklb 2.8.059 (if I'm understanding correctly!?) also seeks to fix some of these punctuation problems — that have been leading to missing thumbnails like: |
Yes. Now the issue is resolved. This PR is tested with xklb 2.8.059. |
To test this PR, follow the instructions outlined in https://github.com/iiab/calibre-web/wiki#how-do-i-test-a-pull-request-pr-, then do:
|
Co-authored-by: A Holt <[email protected]>
@deldesir is there a specific example this PR fixes, that xklb 2.8.059 does not fix? |
xklb 2.8.059 added support to get both video file and thumbnail in the same folder when outtmpl is set externally. Video files and thumbnails are no longer named after the video_id. The directories are no longer placed into a folder named after the extractor name (YouTube, Vimeo...) and outtmpl downloads everything where the script is run, not inside TMP_DOWNLOADS_DIR anymore. Calibre-Web has to adapt with all these changes, thus #177. |
|
Co-authored-by: A Holt <[email protected]>
Central Design Question that might deserve its own ticket:
|
🙏 This PR is opening up existentially critical questions — that families and educators care about deeply in all countries — so learning materials their lives depend on don't disappear or get excessively / accidentally mangled! 🙏 Even if we're not quite there yet obviously! ✊ |
For now yes
Will do |
We retrieve them directly from xklb-metadata.db already per |
Great News! ASIDE: Does Calibre-Web similarly preserve literary-not-video E-Book titles & metadata, in a completely intact / archival way — or not quite yet? |
Yes, in /library.calibre-web/metadata.db > books.title |
Extremely valuable explanations, thanks to @deldesir ! AI² = Articulate Assumptions + Intuition + Intention 🏞️ |
Set "out directory" template externally so video file + thumbnail can be retrieved. This should fix the missing thumbnail issue explained in #171 (comment).
Tested on Ubuntu 24.04