Adjust message to warn about problematic videos [e.g. "live" videos, that might not really be live anymore, but still fail to download]

[deldesir]

Tested together with #193

Unavailable videos returns a different message:

Tested on Ubuntu 24.04

[holta]

@codewiz review with PR #193 if you can?!

[holta]

@deldesir consider adding an else clause below Line 170?

(Including a generic error message explaining — as best we can guess anyway — what might have caused this?!)

[codewiz]

I don't quite understand why we're taking the first error where the extractor_id matches the media_url.

Couldn't we take all records (or the first record) where webpath = media_url and error is not empty?

errors = conn.execute(
    "SELECT error FROM media WHERE webpath = ? AND error != ''", (self.media_url,))
    .fetchone()

And we could also get the id column in one query:

(id, error) = conn.execute(
    "SELECT id, error FROM media WHERE webpath = ? AND error != ''", (self.media_url,))
    .fetchone()

[deldesir]

Good point. However, due to SQLite UNIQUE constraint, we don't expect 2 relevant records. And this record should be deleted right after to allow the user to force redownload. If ever another record with the same extractor ID is present, it will never match because its webpath would have a timestamp appended to it or its error column would not be NULL.

[holta]

@deldesir consider adding an else clause below Line 170?

(Including a generic error message explaining — as best we can guess anyway — what might have caused this?!)

Defensive Programming:

• Why is there no else clause?
• What's the most meaningful error message we can communicate within an else clause?

[deldesir]

@deldesir consider adding an else clause below Line 170?
(Including a generic error message explaining — as best we can guess anyway — what might have caused this?!)

Defensive Programming:

• Why is there no else clause?
• What's the most meaningful error message we can communicate within an else clause?

Done in 017afed