Integration tests #291
Open
Integration tests #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deldesir can you review this❓ |
|
I am still at it. Will follow up ASAP. |
holta
reviewed
Dec 12, 2024
| And you can just run headless: | ||
|
|
||
| ``` | ||
| HEADLESS=false pytest -s |
There was a problem hiding this comment.
HEADLESS=false pytest -s
@thotmx is Line 175 supposed to be identical to Line 181?
(Can you clarify? If possible!)
deldesir
reviewed
Dec 14, 2024
| # Fixture to save information to use through steps | ||
| @pytest.fixture | ||
| def step_context(): | ||
| return {} |
There was a problem hiding this comment.
Suggested change
| return {} | |
| """Fixture to save information to use through steps.""" | |
| return {} |
| @then('see the information for logged users') | ||
| def _(browser): | ||
| """see the information for logged users""" | ||
| assert browser.is_text_present('Books'), 'Book test' |
There was a problem hiding this comment.
Consider using a more descriptive error message
Suggested change
| assert browser.is_text_present('Books'), 'Book test' | |
| assert browser.is_text_present('Books'), 'Expected "Books" text to be visible on the home page' |
| def _(browser): | ||
| """see the information for logged users""" | ||
| assert browser.is_text_present('Books'), 'Book test' | ||
| assert browser.is_text_present('Download to IIAB'), 'IIAB button' |
There was a problem hiding this comment.
A more descriptive error message would be better here too
Suggested change
| assert browser.is_text_present('Download to IIAB'), 'IIAB button' | |
| assert browser.is_text_present('Download to IIAB'), 'Expected "Download to IIAB" button for logged users' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my approach for integration tests. The goal of this PR is to create a simple foundation to add integration tests for Calibre-web.
I left all the historical commits, so you can verify the different approaches for that.
Summary:
The whole IIAB testing would be better to setup in the IIAB project, or as a external project. But it would require setting up a CI infraestructure because the Github action constraints.
Technical part:
This approach uses:
Add a Github action workflow too.
Works with chrome browser and you can change an environment variable to verify the navigation (debugging) or use the headless approach.