Discarded Updates (PR polluted) #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid duplication
Use native HTML5 video player
Play video directly using native HTML5 player
Co-authored-by: A Holt <[email protected]>
Remove original file
Pin max format
Create calibe-web-nginx.conf
Fix OOM issue
Co-authored-by: A Holt <[email protected]>
Update OOM fix
Update calibre-web-nginx.conf
Sync with upstream
This ensures that access is restricted to only video files with "webm" or "mp4" extensions within the /library/calibre-web/ path. Any other files or directories are denied access.
|
Is this PR a possible alternative to... ? Can scripts/omg.yml be preserved (without any changes) as a result of... ? |
deldesir
changed the title
|
To answer your questions...
No, it's not. * PR Fix OOM issue - affecting large videos' playback #51 is Ok. The wide access issue was caused by the nginx conf badly set up
Yes. The clean * PR Deny wide access to entire calibre-web library directory #57 ensure that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.