Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle case where single router name for 2.4 and 5 GHz #581

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tim-moody
Copy link
Contributor

Connecting by ssid can get either 2.4 or 5 GHz, and the latter breaks hostapd.

@tim-moody
Copy link
Contributor Author

@avni @holta please test:

Test cases:

  • router uses same name for both frequencies, but only 2.4GHz can be selected
  • on reboot connection remains on 2.4GHz
  • router has space in name
  • user mistypes password
  • user then corrects password
  • user clicks forget all all wifi connections and starts over

@holta
Copy link
Member

holta commented Aug 15, 2024

Looks very promising. So far I haven't had time to test.

@tim-moody's background tests:

@holta
Copy link
Member

holta commented Aug 15, 2024

@avni might have time to test on Saturday?!

@tim-moody tim-moody merged commit 6fad108 into iiab:master Aug 16, 2024
@avni
Copy link
Member

avni commented Aug 23, 2024

I will test this next week - traveling currently.

@avni
Copy link
Member

avni commented Aug 26, 2024

@tim-moody for the first test case:

router uses same name for both frequencies, but only 2.4GHz can be selected

I'm not clear what you mean by 'only 2.4GHz can be selected'? How would I disable the 5GHz from being selected as part of this test?

@tim-moody
Copy link
Contributor Author

@avni the test is to make sure that the app doesn't allow selection of 5GHz even if one is available.

@avni
Copy link
Member

avni commented Aug 28, 2024

For #581, I think I need help understanding how to test and simulate the situation described. I updated my router, disabled SON, have 2.4GHz and 5GHz bands enabled with the same SSID, but not sure what to do now. I still only see one SSID in the Wifi list. Happy to do a live session @tim-moody or @holta if one of you can help. 🙏

Screenshot 2024-08-28 at 1 29 40 PM

@tim-moody
Copy link
Contributor Author

I think that's a pass
If you saw the name twice it would be a fail.

A further test would be if you connect iiab to the router and the hotspot still works then you connected on 2.4.

If you reboot iiab and it reconnects to 2.4 and hotspot still works then I think we are there.

@avni
Copy link
Member

avni commented Aug 28, 2024

I think that's a pass
If you saw the name twice it would be a fail.

[edited] I think I'm doing this wrong. I have a laptop with a VM that IIAB is installed on. IIAB is not installed on the host computer (the laptop). The screenshot above is from the laptop and shows the Wifi connections from that machine (OS == MacOS 14.0, M1). I think I instead need to test from an RPi with IIAB installed and have it connect directly to a Wifi router. Does that sound right?

@tim-moody
Copy link
Contributor Author

Yes

@avni
Copy link
Member

avni commented Sep 24, 2024

Tested from an RPi and TLDR is it works successfully.

  1. Disabled SON, have 2.4GHz and 5GHz bands enabled with the same SSID
  2. Connected IIAB to a router, and hotspot works.
  3. Rebooted RPi, it connected to the 2.4 and hotspot still works.

🚀 🏁 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants