Expose Run.is_default in facade
#153
Open
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## enh/remove-superfluous-ellipses #153 +/- ##
===============================================================
Coverage 88.4% 88.4%
===============================================================
Files 231 231
Lines 8099 8103 +4
===============================================================
+ Hits 7165 7169 +4
Misses 934 934
|
glatterf42
force-pushed
the
enh/run-clone
branch
3 times, most recently
from
c0d84c8 to
ed0a184
Compare
glatterf42
changed the base branch from
enh/run-clone
to
enh/remove-superfluous-ellipses
glatterf42
force-pushed
the
enh/expose-run-is-default
branch
from
78a5825 to
71c0e69
Compare
|
It's probably best to make this a |
meksor
requested changes
Apr 16, 2025
| @@ -64,14 +64,19 @@ def meta(self) -> "RunMetaFacade": | |||
| def meta(self, meta: dict[str, PrimitiveTypes | np.generic | None]) -> None: | |||
| self._meta._set(meta) | |||
|
|
|||
| def is_default(self) -> bool: | |||
There was a problem hiding this comment.
Suggested change
| def is_default(self) -> bool: | |
| @property | |
| def is_default(self) -> bool: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on iiasa/ixmp#552, I realized that
ixmp4.core.Runshould expose itsis_defaultvalue, which is already present inrun._model.This PR exposes the value by using a function (and tests that calling
set_as_default()andunset_as_default()updateis_default()). It could also be a property, though it's more dynamic than e.g.Run.idorRun.model, that's why I opted for a function: to indicate that this value needs to be retrieved when it's requested.