Bugfix v1.0.2 #40
Open
Bugfix v1.0.2 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, in line 1920 in frame.py: stat = measurement_status << 2 This should be written this way: stat = measurement_status << 1 because, according to the standard, PMU sync takes only 1 bit, so if we shift this two times, we have one zero more than we actually need to have. Next, in line 1955 should be: measurement_status = DataFrame.MEASUREMENT_STATUS_WORDS[stat >> 14] If we shift this one 15 times, we will loose less significant bit in Data error bits. time_quality and trigger_reason should be shifted to get exact numbers from TIME_QUALITY_WORDS and TRIGGER_REASON_WORDS dictionaries.
Should be written (2**24-1) to get 24-bit number (in binary - "111111111111111111111111").
According to C37.118 standard, the most significant bit in Data format defines representation of FREQ/DFREQ. If this bit is logical "1", frequency is shown by floating point, otherwise 16-bit integer. If we have representation in 16-bit integer, than FREQ is frequency deviation from nominal in mHz. In other case it is actual frequency value ( I think in mHz too).
This reverts commit c56bc9e.
According to C37.118 standard, the most significant bit in Data format defines representation of FREQ/DFREQ. If this bit is logical "1", frequency is shown by floating point, otherwise 16-bit integer. If we have representation in 16-bit integer, than FREQ is frequency deviation from nominal in mHz. In other case it is actual frequency value.
When FREQ is 16-bit integer, it is considered to be frequency deviation from nominal (in mHz) and it is added to nominal frequency value to get actual value of frequency (see one of my commits) , divided by 1000. When FREQ is floating points, it is actual frequency value that should be written in Hz (because range is -32767 <= freq<=32767, so max value would be 32.767Hz if we use mHz for input). This is only my understanding of standard and should be checked by others.
Test for sending data from PMU to PDC when FREQ is random short integer.
Tests sending data from PMU to PDC when FREQ is floating point.
Changed FREQ - REAL to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.