Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Implemented Games page according to design #11

Merged
merged 5 commits into from
Oct 5, 2021
Merged

feat : Implemented Games page according to design #11

merged 5 commits into from
Oct 5, 2021

Conversation

siddhantsingh186
Copy link
Contributor

@siddhantsingh186 siddhantsingh186 commented Oct 4, 2021 •
edited
Loading

Fixes #8 Make Games Page

@prathmeshkhandelwal1
Copy link
Member

prathmeshkhandelwal1 commented Oct 4, 2021 •
edited
Loading

@siddhantsingh186 you mentioned wrong issue here ig.

@siddhantsingh186
Copy link
Contributor Author

@siddhantsingh186 you mentioned wrong issue here ig.

Sorry, my bad! I have updated the PR comment with the correct issue.

@prathmeshkhandelwal1
Copy link
Member

Can you add proper Screen shot of pages, as we don't have any netlify preview here.

@siddhantsingh186
Copy link
Contributor Author

Can you add proper Screen shot of pages, as we don't have any netlify preview here.

Sure
games2
games1
games3
.

prathmeshkhandelwal1
prathmeshkhandelwal1 requested changes Oct 5, 2021
View reviewed changes
src/components/games/Games.js Outdated Show resolved Hide resolved
src/components/games/Games.js Outdated Show resolved Hide resolved
@siddhantsingh186
Copy link
Contributor Author

@prathmeshkhandelwal1 requested changes are done in the latest commit.

@prathmeshkhandelwal1
Copy link
Member

@prathmeshkhandelwal1 requested changes are done in the latest commit.

Conflicts are remaining, this arises due the merge of another pr by akshat, can you resolve that please.

@siddhantsingh186
Copy link
Contributor Author

@prathmeshkhandelwal1 requested changes are done in the latest commit.

Conflicts are remaining, this arises due the merge of another pr by akshat, can you resolve that please.

Done👍

@prathmeshkhandelwal1 prathmeshkhandelwal1 merged commit 3d5c15e into iiitv:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathmeshkhandelwal1 prathmeshkhandelwal1 prathmeshkhandelwal1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Games Page
2 participants
@siddhantsingh186 @prathmeshkhandelwal1