1743 Usunięcie efektów kształcenia #1780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cez02
commented
Jan 5, 2025
Cez02
commented
- Usunięcie modelu Effects
- Usunięcie filtru grup efektów z panelu admina i stron użytkownika
- Usunięcie metody get_completed_effects z modelu CompletedCourses
lgpawel
reviewed
Jan 14, 2025
| @@ -74,26 +72,6 @@ class FreedayAdmin(admin.ModelAdmin): | |||
| ordering = ('-day',) | |||
|
|
|||
|
|
|||
| class EffectsListFilter(SimpleListFilter): | |||
There was a problem hiding this comment.
To chyba już teraz był martwy kod, prawda? Proszę przy okazji o przejechanie się po historii git bisect i stwierdzenie, od kiedy tak jest, tj. kiedy znikają odniesienia do tej klasy.
There was a problem hiding this comment.
Z tego co widzę to tak, jest to martwy kod. Nastąpiło to razem z usunięciem klasy CourseEntityAdmin w commitcie ef0460f. Potwierdzę to rano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.