Apply consistent style between current and last cards #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a more consistent display in the last card pane by recreating the last card stats data table, based on the current card pane’s table format. Also applies the default styling from the first load rather than waiting for the next card to force the last card stats to display, where the links to the system CSS files are found.
|
Thanks for sharing this. Sorry for answering so late. On my computer I don't see any difference with or without your commit. So it's still on my todo list to look more into this. I haven't merged this yet because I'm afraid that if something changes in Anki I can't maintain your js code. Maybe I should add an option to optionally enable your code? But I'll be pretty busy until the end of January. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a more consistent display in the last card pane by recreating the last card stats data table, based on the current card pane’s table format. Also applies the default styling from the first load rather than waiting for the next card to force the last card stats to display, where the links to the system CSS files are found.
Solves two issues:
<head>section so it's available on first load.In solving issue 2 above, an arbitrary small delay had to added to allow Anki's provided js to make its own modifications to the DOM. It's a little fragile and may need to be adjusted but I couldn't think of any other signal to latch onto. I've only tested it on macOS 11.6, Intel; Anki 2.1.53, Qt6
@NSBum - aka u/OjisanSeiuchi
First load, no CSS
After the above issues addressed
And night mode is unaffected