-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE 271] Move/Size step min size and default stepping size change. #273
base: master
Are you sure you want to change the base?
Conversation
…the config window and changed their default step for up/down actions to be 0.0125
It probably doesn't need to be 0.0001. It can probably be 0.0005 without loss of functionality, because useful steps are usually repeatedly divisions by 2: 0.5 Btw, does changing the parameters of just the spinner boxes also prevent rounding the coordinates down the line? Is this tested? |
I looked for reference to those two inputs and couldn't find anything about rounding. I'll double check that. 0.03125 would not be possible with 0.0005 either. |
…and moveStep in the options set to match html (0.0125) and updated the round function to have 4 decimal places, instead of two.
@MarkJeronimus I tested and just fixed a couple rounding issues. Floating point addition in JS is silly. |
Best way is to adopt the strategy used by monetary calculations. Use integer fixed-point precision (i.e. cents or hundreds of cents) and only convert to floating point when presenting values to the user. I just realized the most common steps also includes the binary divisions of 0.75". Thats: You could use integer units which are 1/64th of an inch (0.015625") which would accommodate all those and the divisions of 0.5". |
I was using 19.05 mm as 1 U. So in my setup in KiCAD, I use a 1.190625 mm grid, which is 1/16th (0.0625) of 1 U based on 19.05. But from what I can tell, this is all based on U, not in or mm, so you could go down to 0.0005 U, if you wanted to. |
FWIW, back in the day I set move step to 0.1, but IJP pushed it back to 0.5. Same with sizes and rotate. |
No description provided.